rebase by Abhinavpv28 · Pull Request #129 · rdkcentral/remote_debugger

Abhinavpv28 · 2025-05-17T16:08:36Z

No description provided.

…ic Updates (#117) * Update rrdInterface.c * Update rrdInterface.c * Update rrdInterface.c * Update cov_build.sh * Update configure.ac * Update rrdInterface.c * Update rrdInterface.h * Update cov_build.sh * Update rrdInterface.c * Update rrdInterface.h * Update rrdInterface.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

…method (#123) * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdCommon.h * Update rrdIarmEvents.c * Update rrdInterface.h * Update rrdCommon.h * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdDynamic.c * Update rrdJsonParser.c * Update rrdCommon.h * Update rrdIarmEvents.c * Update rrdInterface.h * Update rrdInterface.h * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdJsonParser.c * Update rrdEventProcess.c * Update rrdJsonParser.c * Update rrdJsonParser.c * Update rrdJsonParser.c * Update rrdEventProcess.c * Update rrdCommon.h * Update rrdIarmEvents.c * Update rrdIarmEvents.c * Update rrdIarmEvents.c

…er Dynam…" (#126) This reverts commit e86dd66.

…method (#125) * Update rrdIarmEvents.c * Update rrdInterface.c * Update rrdInterface.c * Update cov_build.sh * Update rrdIarmEvents.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

…d message type (SCXI11BEI) (#121) * Update rrdJsonParser.c * Update rrdJsonParser.c * Update rrdEventProcess.c * Update rrdInterface.c * Update rrdInterface.c * Update rrdInterface.c * Update rrdJsonParser.c * Update rrdInterface.c * Update rrdJsonParser.c * Update rrdEventProcess.c * Update rrdJsonParser.c * Update rrdEventProcess.c * Update rrdEventProcess.c * Update rrdInterface.c * Update rrdInterface.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

CLAassistant · 2025-05-17T16:08:41Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ nhanasi
✅ venkat0557
✅ Abhinavpv28
✅ AravindanNC
✅ Alan-Ryan
❌ naveenkumarhanasi
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Added release to fix remotedebugger bug fixes

… process exited with error code." (#134) * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c

…rogress (#136) * Update rrdInterface.c * Update rrdInterface.c * Update rrdInterface.c

Release 1.2.8 tag for RRD

* Update Client_Mock.cpp * Update Client_Mock.h * Update rrdUnitTestRunner.cpp * Update rrdUnitTestRunner.cpp * Update rrdUnitTestRunner.cpp * Update rrdInterface.c * Update rrdInterface.h * Update rrdRunCmdThread.c * Update rrdIarmEvents.c * Update rrdInterface.h * Update rrdDynamic.c * Update code-coverage.yml

Create deepsleep_main.c Update Makefile Create power_controller.h Update run_l2.sh Update cov_build.sh Create pwrMgr.h Update cov_build.sh Update cov_build.sh Update Makefile Rename deepsleep_main.c to main.c Update Makefile update Makefile Delete test/functional-tests/tests/rrdIarmEvents.c Update run_l2.sh Update remote_debugger.json Update remote_debugger.json Create test_deepsleep_static.py Update run_l2.sh Update run_l2.sh Create test_deepsleep_dynamic.py Update run_l2.sh Update rrdInterface.c Update create_json.sh Create test_append.py Create test_category.py Update test_rrd_dynamic_profile_missing_report.py Create test_rrd_dynamic_with_download_harmful.py Create test_rrd_negative.py Update configure.ac Update cov_build.sh Update run_l2.sh Update main.c Rename main.c to deepsleep_main.c Update Makefile Create rrd_append_report.feature Create rrd_deepsleep_static.feature Create rrd_deepsleep_dynamic.feature Create rrd_dynamic_with_download_harmful_report.feature Update rrd_dynamic_profile_missing_report.feature Update test_rrd_dynamic_profile_missing_report.py Update cov_build.sh Update test_rrd_single_instance.py Update test_category.py Update run_l2.sh Update test_rrd_dynamic_profile_missing_report.py Update rrdInterface.c Update rrdInterface.c Update rrdInterface.c Update rrdIarmEvents.c Update rrdIarmEvents.c Delete test/functional-tests/tests/test_deepsleep_dynamic.py Delete test/functional-tests/tests/test_rrd_negative.py Update run_l2.sh Update test_category.py Update cov_build.sh Update configure.ac Update configure.ac Delete test/functional-tests/features/rrd_deepsleep_dynamic.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature Delete test/functional-tests/tests/test_rrd_dynamic_with_download_harmful.py Delete test/functional-tests/tests/deepsleep_main.c Delete test/functional-tests/tests/Makefile Update run_l2.sh Update run_l2.sh Delete test/functional-tests/features/rrd_dynamic_with_download_harmful_report.feature Create rrd_dynamic_profile_subcategory_report.feature Update run_l2.sh Rename test_append.py to test_rrd_append_report.py Rename test_category.py to test_rrd_dynamic_subcategory_report.py Rename test_deepsleep_static.py to test_rrd_deepsleep_static_report.py Rename rrd_deepsleep_static.feature to rrd_deepsleep_static_report.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature

RDK-56291 - [RDKE] Increase L2 Test Coverage For Remote Debugger : Target 80% [ Phase 2 ]

…elop Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

…rget 80% [ Phase 2 ] (#157) * Update rrdInterface.c * Update rrdIarmEvents.c * Update configure.ac * Update cov_build.sh * Update remote_debugger.json * Update create_json.sh * Create Makefile * Create deepsleep_main.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

RRD 1.2.9 release

… C (#167) * Add comprehensive HLD documentation for uploadRRDLogs.sh migration to C - Requirements document with functional specs, I/O definitions, and constraints - High-Level Design with architecture, module breakdown, and data flows - Detailed flowcharts for all major operations (Mermaid + text-based) - Sequence diagrams showing component interactions - Low-Level Design with complete C code, data structures, and implementations Documentation covers migration of uploadRRDLogs.sh to embedded C program optimized for low-memory, low-CPU embedded systems with full error handling, security considerations, and platform portability. - Replace custom MAC retrieval logic with TR-181 parameters via RBus - Device.DeviceInfo.X_COMCAST-COM_STB_MAC (Video) - Device.DeviceInfo.X_COMCAST-COM_CM_MAC (Broadband) - Device.X_CISCO_COM_MACAddress (Alternative) - Add cache file fallback (/tmp/device_details.cache, /tmp/estb_mac) - Add early exit optimization in config parser when all required properties found - Mark libarchive as mandatory dependency, remove tar command fallback

Copilot

Pull request overview

This PR is a rebase containing multiple feature additions and improvements to the Remote Debugger component, including:

Enhanced L2 test coverage with new test scenarios for dynamic subcategory reports, deep sleep, and append functionality
Deep sleep event handling support with power manager integration
Unit test infrastructure improvements with comprehensive mock support
Documentation additions for uploadRRDLogs migration to C
Build system updates and workflow improvements

Key Changes

New L2 test files for dynamic profiles, deep sleep scenarios, and append operations
Enhanced PID handling in single instance tests with proper parsing
Deep sleep event processing with power controller integration
Memory management improvements in event processing
Comprehensive unit test coverage expansion
New mock infrastructure for power manager testing

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/functional-tests/tests/test_rrd_single_instance.py	Enhanced PID handling with proper list parsing and validation
test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py	New L2 test for dynamic profile subcategory reports
test/functional-tests/tests/test_rrd_deepsleep_static_report.py	New L2 test for deep sleep static reports
test/functional-tests/tests/test_rrd_append_report.py	New L2 test for append request scenarios
test/functional-tests/tests/power_controller.h	New power controller API definitions for deep sleep
test/functional-tests/tests/deepsleep_main.c	Test main for deep sleep event handling
src/rrdRunCmdThread.c	Added RemainAfterExit flag to systemd-run commands
src/rrdJsonParser.c	Added deep sleep detection logic
src/rrdInterface.h/c	Interface updates for IARM support compilation
src/rrdIarmEvents.c	Refactored power manager event handling
src/rrdEventProcess.c	Improved memory management with null checks
src/rrdDynamic.c	Fixed buffer size calculation in string copy
src/unittest/rrdUnitTestRunner.cpp	Extensive unit test additions and mock updates
src/unittest/mocks/*.h/cpp	Updated mock infrastructure for testing
docs/*.md	New comprehensive documentation for uploadRRDLogs
configure.ac	Added L2 support configuration option
cov_build.sh	Updated build flags for coverage
CHANGELOG.md	Version updates and changelog entries
.github/workflows/*	Workflow improvements and CLA addition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T23:06:54Z

test/functional-tests/tests/test_rrd_deepsleep_static_report.py

+    DEBUG_FILE = "Adding Details of Debug commands to Output File"
+    assert DEBUG_FILE in grep_rrdlogs(DEBUG_FILE)
+
+    issue_string = "DEEPSLEEP"


Variable issue_string is not used.

Copilot · 2025-12-04T23:06:54Z

test/functional-tests/tests/test_rrd_append_report.py

@@ -0,0 +1,134 @@
+import json
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2025-12-04T23:06:54Z

test/functional-tests/tests/test_rrd_deepsleep_static_report.py

+# limitations under the License.
+##########################################################################
+
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2025-12-04T23:06:54Z

test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py

+
+import json
+import subprocess
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2025-12-04T23:06:55Z

test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py

+# limitations under the License.
+##########################################################################
+
+import json


Import of 'json' is not used.

* RDK-58172: integrate dcm-agent uploadstblogs and cleanup logging; update Makefile and upload flow * Add unit tests for RRD upload orchestration This file contains unit tests for the RRD upload orchestration, covering various aspects such as configuration loading, system information retrieval, log directory validation, and the entire upload workflow. * Update Makefile.am * Remove uploadRRDLogs program from Makefile * Refactor uploadDebugoutput to use upload API Updated the uploadDebugoutput function to call the upload API instead of executing a script. Enhanced logging for upload orchestration success and failure. * Refactor upload orchestration into rrd_upload_orchestrate Refactor upload orchestration logic into a separate function and remove deprecated main function. * Update rrd_config.h * Include common_device_api.h in rrd_sysinfo.h Added inclusion of common_device_api.h for device API access. * Add comprehensive functional tests for C API upload orchestration - Add BDD feature file with 20 test scenarios for rrd_upload_orchestrate - Add Python test implementation with 14 test functions - Test coverage includes: * Valid and invalid parameter handling * Configuration loading from multiple sources (properties, RFC, DCM) * MAC address retrieval and timestamp generation * Issue type sanitization and normalization * Archive creation and format validation * Upload execution and lock handling * Cleanup operations * Error code propagation (codes 1-11) * Comprehensive logging verification * Integration with uploadDebugoutput wrapper - Tests validate the complete flow from event trigger through C API execution to upload completion - Helper class provides utilities for test setup, archive validation, and log verification Refactor source validation and log handling. Improve error handling for directory operations and add functionality to move live logs. * Refactor log upload handling and cleanup process Updated log upload process to handle LOGUPLOAD_ENABLE case and adjusted archive creation and upload paths.

* RDKEMW-12334-The log entries in remote-debugger.log RDKEMW-12334-The log entries in remote-debugger.log differ between C binary files and script files when compared * Change the log from Debug to Info * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T19:30:59Z

test/functional-tests/tests/test_rrd_c_api_upload.py

+    if '.' in ISSUE_STRING:
+        ISSUE_NODE, ISSUE_SUBNODE = ISSUE_STRING.split('.')
+    else:
+        node = ISSUE_STRING


Variable node is not used.

Copilot · 2026-01-21T19:31:00Z

test/functional-tests/tests/test_rrd_c_api_upload.py

+        ISSUE_NODE, ISSUE_SUBNODE = ISSUE_STRING.split('.')
+    else:
+        node = ISSUE_STRING
+        subnode = None


Variable subnode is not used.

Copilot · 2026-01-21T19:31:00Z

test/functional-tests/tests/test_rrd_c_api_upload.py

+        node = ISSUE_STRING
+        subnode = None
+
+    ISSUE_FOUND = f"Issue Data Node: {ISSUE_NODE} and Sub-Node: {ISSUE_SUBNODE} found in Static JSON File /etc/rrd/remote_debugger.json"


Variable ISSUE_FOUND is not used.

Copilot · 2026-01-21T19:31:00Z

test/functional-tests/tests/test_rrd_c_api_upload.py

+# limitations under the License.
+##########################################################################
+
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

RRD release 1.3.1

…ode (#178) * Update Makefile.am * Update rrdExecuteScript.c * Update rrd_upload.h * Update Makefile.am * Update Makefile.am * Update Makefile.am * Update Makefile.am --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This pull request addresses Coverity defects in the RDK Remote Debugger Device Management code, focusing on fixing memory leaks, buffer overflows, and resource handling issues. Changes: Added NULL checks for memory allocations (malloc, strdup, fread) with proper error handling and resource cleanup Fixed buffer overflow vulnerabilities by using correct size parameters in strncpy/strncat operations Corrected file pointer closure to only occur when pointers are valid (v_secure_pclose moved inside if blocks) Fixed memory management issues with rfcbuf allocations and ownership Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

Remote Debugger 1.3.2 release

Copilot

Pull request overview

Copilot reviewed 63 out of 63 changed files in this pull request and generated 9 comments.

Copilot · 2026-03-20T19:05:55Z

test/functional-tests/tests/test_rrd_append_report.py

+# Path to the existing JSON file
+file_path = "/etc/rrd/remote_debugger.json"
+
+# Read the existing JSON data
+with open(file_path, "r") as json_file:
+    data = json.load(json_file)
+
+# New entry to add
+new_entry = {
+    "Test": {
+        "TestRun4": {
+            "Commands": "cat /version.txt;cat /tmp/.deviceDetails.cache",
+            "Timeout": 10
+        }
+    }
+}
+
+# Update the JSON data with the new entry
+data.update(new_entry)
+
+# Write the updated data back to the JSON file
+with open(file_path, "w") as json_file:
+    json.dump(data, json_file, indent=4)


This test module performs file I/O and overwrites /etc/rrd/remote_debugger.json at import time. If the file is missing or the test runner lacks permissions, collection will fail before any tests run, and it also makes the suite order-dependent. Move this JSON read/update/write logic into a dedicated test (or a setup/fixture) and prefer writing to a temporary copy of the config rather than mutating /etc directly.

Copilot · 2026-03-20T19:05:55Z

src/rrdEventProcess.c

        pIssueNode = (issueNodeData *)malloc(sizeof(issueNodeData));
        if(pIssueNode)
        {
            getIssueInfo((char *)rbuf->mdata, pIssueNode); // issue data extract
            RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Extracted Node %s and Sub Node %s \n", __FUNCTION__, __LINE__, pIssueNode->Node, pIssueNode->subNode);
            if (rbuf->appendMode)
            {
                RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Received append request to process static and dynamic profiles... \n", __FUNCTION__, __LINE__);
                RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Reading dynamic profile command info... \n", __FUNCTION__, __LINE__);
                dynamicprofiledata = processIssueTypeInDynamicProfileappend(rbuf, pIssueNode);
                if (dynamicprofiledata == NULL)
                {
                    RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Dynamic Profie Info not found, Download RDM package... \n", __FUNCTION__, __LINE__);
                }
                else
                {
                    RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Read complete for Dynamic Profile: RFCValue: %s, Command: %s, Timeout: %d... \n", __FUNCTION__, __LINE__, dynamicprofiledata->rfcvalue, dynamicprofiledata->command, dynamicprofiledata->timeout);
                    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Reading static profile command info... \n", __FUNCTION__, __LINE__);
                    staticprofiledata = processIssueTypeInStaticProfileappend(rbuf, pIssueNode);
                    if (staticprofiledata == NULL)
                    {
                        RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Static Command Info not found for IssueType!!! \n", __FUNCTION__, __LINE__);
+                        // Free dynamicprofiledata since we can't proceed
+                        if (dynamicprofiledata != NULL)
+                        {
+                            if (dynamicprofiledata->rfcvalue != NULL)
+                            {
+                                free(dynamicprofiledata->rfcvalue);
+                            }
+                            if (dynamicprofiledata->command != NULL)
+                            {
+                                free(dynamicprofiledata->command);
+                            }
+                            free(dynamicprofiledata);
+                        }
                    }
                    else
                    {
                        RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Read complete for Static Profile: RFCValue: %s, Command: %s, Timeout: %d... \n", __FUNCTION__, __LINE__, staticprofiledata->rfcvalue, staticprofiledata->command, staticprofiledata->timeout);
-                        //Remove the double quotes
-                        size_t staticstrlen = strlen(staticprofiledata->command);
-                        size_t dynamicstrlen = strlen(dynamicprofiledata->command);
-                        if (staticstrlen > 0 && staticprofiledata->command[staticstrlen - 1] == '"') {
-                            staticprofiledata->command[staticstrlen - 1] = '\0';
-                        }
-                        if (dynamicprofiledata->command[0] == '"') {
-                            dynamicprofiledata->command[0] = COMMAND_DELIM;
+
+                        // Check if commands are NULL before using them
+                        if (dynamicprofiledata->command == NULL || staticprofiledata->command == NULL)
+                        {
+                            RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Command is NULL in dynamic or static profile... \n", __FUNCTION__, __LINE__);
+                            // Free dynamicprofiledata
+                            if (dynamicprofiledata != NULL)
+                            {
+                                if (dynamicprofiledata->rfcvalue != NULL)
+                                {
+                                    free(dynamicprofiledata->rfcvalue);
+                                }
+                                if (dynamicprofiledata->command != NULL)
+                                {
+                                    free(dynamicprofiledata->command);
+                                }
+                                free(dynamicprofiledata);
+                            }
+                            // Free staticprofiledata
+                            if (staticprofiledata != NULL)
+                            {
+                                if (staticprofiledata->rfcvalue != NULL)
+                                {
+                                    free(staticprofiledata->rfcvalue);
+                                }
+                                if (staticprofiledata->command != NULL)
+                                {
+                                    free(staticprofiledata->command);
+                                }
+                                free(staticprofiledata);
+                            }
                        }
-                        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Static Profile Commands: %s, Dynamic Profile Commands: %s\n", __FUNCTION__, __LINE__, staticprofiledata->command, dynamicprofiledata->command);
-
-                        size_t appendstrlen = ((staticstrlen - 1) + dynamicstrlen + 1);
-                        char *appendcommandstr = (char *)realloc(staticprofiledata->command, appendstrlen);
-                        if (appendcommandstr == NULL) {
-                            RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Memory Allocation Failed... \n", __FUNCTION__, __LINE__);
+                        else
+                        {
+                            //Remove the double quotes
+                            size_t staticstrlen = strlen(staticprofiledata->command);
+                            size_t dynamicstrlen = strlen(dynamicprofiledata->command);
+                            if (staticstrlen > 0 && staticprofiledata->command[staticstrlen - 1] == '"') {
+                                staticprofiledata->command[staticstrlen - 1] = '\0';
+                                staticstrlen--; // Update length after removing trailing quote
+                            }
+                            if (dynamicprofiledata->command[0] == '"') {
+                                dynamicprofiledata->command[0] = COMMAND_DELIM;
+                            }
+                            RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Static Profile Commands: %s, Dynamic Profile Commands: %s\n", __FUNCTION__, __LINE__, staticprofiledata->command, dynamicprofiledata->command);
+
+                            size_t appendstrlen = (staticstrlen + dynamicstrlen + 1);
+                            char *appendcommandstr = (char *)realloc(staticprofiledata->command, appendstrlen);
+                            if (appendcommandstr == NULL) {
+                                RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Memory Allocation Failed... \n", __FUNCTION__, __LINE__);
+                                // Free staticprofiledata on realloc failure
+                                if (staticprofiledata != NULL)
+                                {
+                                    if (staticprofiledata->rfcvalue != NULL)
+                                    {
+                                        free(staticprofiledata->rfcvalue);
+                                    }
+                                    if (staticprofiledata->command != NULL)
+                                    {
+                                        free(staticprofiledata->command);
+                                    }
+                                    free(staticprofiledata);
+                                    staticprofiledata = NULL; // Set to NULL to prevent double-free
+                                }
+                                // Free dynamicprofiledata on realloc failure
+                                if (dynamicprofiledata != NULL)
+                                {
+                                    if (dynamicprofiledata->rfcvalue != NULL)
+                                    {
+                                        free(dynamicprofiledata->rfcvalue);
+                                    }
+                                    if (dynamicprofiledata->command != NULL)
+                                    {
+                                        free(dynamicprofiledata->command);
+                                    }
+                                    free(dynamicprofiledata);
+                                    dynamicprofiledata = NULL; // Set to NULL to prevent double-free
+                                }
+                            }
+                            else
+                            {
+                                strcat(appendcommandstr, dynamicprofiledata->command);
+                                staticprofiledata->command = appendcommandstr;
+                                RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Updated command after append from dynamic and static profile: %s \n", __FUNCTION__, __LINE__, staticprofiledata->command);
+                                RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Executing Commands in Runtime Service... \n",__FUNCTION__,__LINE__);
+                                checkIssueNodeInfo(pIssueNode, NULL, rbuf, false, staticprofiledata);
+                                // NOTE: staticprofiledata is freed by executeCommands() via checkIssueNodeInfo()
+                                // Do NOT free staticprofiledata here to avoid double-free
+                            }
+                            // Free dynamicprofiledata after use
+                            if (dynamicprofiledata != NULL)
+                            {
+                                if (dynamicprofiledata->rfcvalue != NULL)
+                                {
+                                    free(dynamicprofiledata->rfcvalue);
+                                }
+                                if (dynamicprofiledata->command != NULL)
+                                {
+                                    free(dynamicprofiledata->command);
+                                }
+                                free(dynamicprofiledata);
+                            }
                        }
-                        strcat(appendcommandstr, dynamicprofiledata->command);
-                        staticprofiledata->command = appendcommandstr;
-                        RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Updated command after append from dynamic and static profile: %s \n", __FUNCTION__, __LINE__, staticprofiledata->command);
-                        RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Executing Commands in Runtime Service... \n",__FUNCTION__,__LINE__);
-                        checkIssueNodeInfo(pIssueNode, NULL, rbuf, false, staticprofiledata); 
                    }
                }
 	    }	    
 	    else if (rbuf->inDynamic)
            {
                RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Checking if Issue marked inDynamic... \n", __FUNCTION__, __LINE__);
                processIssueTypeInDynamicProfile(rbuf, pIssueNode);
            }
            else
            {
                RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Issue not marked as inDynamic... \n", __FUNCTION__, __LINE__);
 		RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Checking Issue from Static... \n", __FUNCTION__, __LINE__);
                processIssueTypeInStaticProfile(rbuf, pIssueNode);
            }
 	    //CID-336989: Resource leak
-	    free(pIssueNode);
        }


processIssueType() allocates pIssueNode via malloc() but it is never freed on any path (the previous free(pIssueNode) was removed). Since this runs per event, this introduces an unbounded memory leak in the daemon. Ensure pIssueNode is freed before returning (including error paths), and avoid freeing it inside helpers that don't own it.

Copilot · 2026-03-20T19:05:55Z

src/rrd_upload.c

+int rrd_upload_cleanup_source_dir(const char *dir_path) {
+    if (!dir_path) return -1;
+
+    RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Removing source directory: %s\n", __FUNCTION__, dir_path);
+
+    char cmd[1024];
+    snprintf(cmd, sizeof(cmd), "rm -rf %s", dir_path);
+
+    int ret = system(cmd);
+    if (ret == 0) {
+        RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Successfully removed source directory: %s\n", 
+                __FUNCTION__, dir_path);
+        return 0;
+    } else {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "%s: Failed to remove source directory: %s (ret: %d)\n", 
+                __FUNCTION__, dir_path, ret);
+        return -1;
+    }
+}


rrd_upload_cleanup_source_dir() builds a shell command and calls system("rm -rf %s"). This is vulnerable to command injection if dir_path contains shell metacharacters, and it also violates the project's stated goal of avoiding system() calls where possible. Replace this with a safe recursive deletion implementation (e.g., nftw()/unlinkat() traversal) and validate that dir_path is within an expected base directory before deleting.

Copilot · 2026-03-20T19:05:56Z

src/rrd_archive.c

+        /* split into prefix and name */
+        size_t prefix_len = name_len - 100 - 1; /* leave room for null */
+        if (prefix_len > sizeof(hdr.prefix)) {
+            RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",
+                    __FUNCTION__, name, name_len);
+            return -1;
+        }
+        strncpy(hdr.prefix, name, prefix_len);
+        hdr.prefix[prefix_len < sizeof(hdr.prefix) ? prefix_len : sizeof(hdr.prefix) - 1] = '\0';
+        strncpy(hdr.name, name + prefix_len + 1, sizeof(hdr.name) - 1);
+        hdr.name[sizeof(hdr.name) - 1] = '\0';


write_tar_header() splits long paths into prefix/name by taking an arbitrary cut (prefix_len = name_len - 101). This doesn't respect tar's requirement that the split occur on a '/' boundary, and can produce archives with invalid/incorrect entry names for paths >100 chars. Prefer splitting at the last '/' that keeps prefix<=155 and name<=100 (or reject paths that can't be represented).

Suggested change

/* split into prefix and name */

size_t prefix_len = name_len - 100 - 1; /* leave room for null */

if (prefix_len > sizeof(hdr.prefix)) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",

__FUNCTION__, name, name_len);

return -1;

}

strncpy(hdr.prefix, name, prefix_len);

hdr.prefix[prefix_len < sizeof(hdr.prefix) ? prefix_len : sizeof(hdr.prefix) - 1] = '\0';

strncpy(hdr.name, name + prefix_len + 1, sizeof(hdr.name) - 1);

hdr.name[sizeof(hdr.name) - 1] = '\0';

/* split into prefix and name at a '/' boundary according to POSIX ustar */

size_t split_index = (size_t)-1;

size_t prefix_len = 0;

size_t name_part_len = 0;

/* search for the rightmost '/' that yields valid prefix/name lengths */

for (size_t i = name_len; i > 0; --i) {

if (name[i - 1] == '/') {

size_t p_len = i - 1; /* characters before '/' */

size_t n_len = name_len - i; /* characters after '/' */

if (p_len > 0 &&

p_len <= sizeof(hdr.prefix) - 1 &&

n_len > 0 &&

n_len <= sizeof(hdr.name) - 1) {

split_index = i - 1;

prefix_len = p_len;

name_part_len = n_len;

break;

}

}

}

if (split_index == (size_t)-1) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",

__FUNCTION__, name, name_len);

return -1;

}

/* copy prefix and name parts, ensuring null termination */

strncpy(hdr.prefix, name, prefix_len);

hdr.prefix[prefix_len] = '\0';

strncpy(hdr.name, name + split_index + 1, name_part_len);

hdr.name[name_part_len] = '\0';

Copilot · 2026-03-20T19:05:56Z

run_l2.sh

 mkdir -p /media/apps/RDK-RRD-Test/etc/rrd

 touch /media/apps/RDK-RRD-Test/etc/rrd/remote_debugger.json
+echo "AA:BB:CC:DD:EE:FF" >> /tmp/.estb_mac


This appends the mock MAC to /tmp/.estb_mac on every run, which will accumulate multiple lines and can break any code that expects a single MAC value. Use overwrite (>) or truncate the file before writing the mock MAC.

Suggested change

echo "AA:BB:CC:DD:EE:FF" >> /tmp/.estb_mac

echo "AA:BB:CC:DD:EE:FF" > /tmp/.estb_mac

Copilot · 2026-03-20T19:05:56Z

test/functional-tests/features/rrd_dynamic_profile_subcategory_report.feature

+    And the issue data node and sub-node should be found in the JSON file
+    And the directory should be created to store the executed output
+    And Sanity check to validate the commands should be executed
+    And Command output shopuld be added to the output file


Typo in step text: "shopuld" should be "should".

Copilot · 2026-03-20T19:05:56Z

test/functional-tests/tests/power_controller.h

+    THERMAL_TEMPERATURE_CRITICAL = 4 /* Critial Thermal Temperature */
+} PowerController_ThermalTemperature_t;


Typo in enum comment: "Critial" should be "Critical".

Copilot · 2026-03-20T19:05:57Z

test/functional-tests/features/rrd_deepsleep_static_report.feature

+    And the issue data node and sub-node should be found in the JSON file
+    And the directory should be created to store the executed output
+    And Sanity check to validate the commands should be executed
+    And Command output shopuld be added to the output file


Typo in step text: "shopuld" should be "should".

Copilot · 2026-03-20T19:05:57Z

src/rrd_config.c

+    // Check BUILD_TYPE for prod override logic (matching shell script lines 81-83)
+    bool is_prod_with_override = (strcmp(config->build_type, "prod") != 0 && file_exists("/opt/dcm.properties"));
+    if (is_prod_with_override) {
+        RDK_LOG(RDK_LOG_WARN, LOG_REMDEBUG, 
+                "%s: Configurable service end-points will not be used for %s Builds due to overriden /opt/dcm.properties!!!\n",
+                __FUNCTION__, config->build_type);
+    } else {


The boolean name is_prod_with_override doesn't match its condition (BUILD_TYPE != prod && /opt/dcm.properties exists). This makes the override logic hard to reason about and easy to misread. Rename it to reflect the actual condition (e.g., non_prod_with_opt_dcm_override) or adjust the condition to match the name.

Abhinavpv28 and others added 6 commits May 5, 2025 15:49

Revert " RDK-56291 L2 Tests And Integration With CI for Remote Debugg…

9ce8a74

…er Dynam…" (#126) This reverts commit e86dd66.

RDKEMW-3380 : Evaluate the Deepsleep Scenario for Static and Dynamic …

0f3b06d

…method (#125) * Update rrdIarmEvents.c * Update rrdInterface.c * Update rrdInterface.c * Update cov_build.sh * Update rrdIarmEvents.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

1.2.7 release changelog updates

d893197

Abhinavpv28 requested a review from a team as a code owner May 17, 2025 16:08

Abhinavpv28 requested a review from a team May 17, 2025 16:08

naveenkumarhanasi and others added 21 commits May 19, 2025 16:40

Merge branch 'release/1.2.7' into main

94ee9ee

Merge tag '1.2.7' into develop

37a89a1

Added release to fix remotedebugger bug fixes

DELIA-68076: RRD Various commands getting "failed because the control…

6ae85f4

… process exited with error code." (#134) * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c

Deploy cla action

43c072b

DELIA-68122 - RRD device stopped running RRD commands, logs show no p…

778c4c1

…rogress (#136) * Update rrdInterface.c * Update rrdInterface.c * Update rrdInterface.c

1.2.8 release changelog updates

84074ba

Merge branch 'release/1.2.8' into main

d5b06c7

Merge tag '1.2.8' into develop

6a54657

Release 1.2.8 tag for RRD

Merge pull request #147 from rdkcentral/feature/deepsleepl2

cbea8fc

RDK-56291 - [RDKE] Increase L2 Test Coverage For Remote Debugger : Target 80% [ Phase 2 ]

Update CODEOWNERS

4c0a052

Merge branch 'develop' into feature/action-deploy-for/develop

1df05e1

Deploy cla action

7d615b3

Merge pull request #137 from rdkcentral/feature/action-deploy-for/dev…

0e466a4

…elop Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

e941880

Merge pull request #163 from rdkcentral/feature/actions/develop-fossid

1f51cb5

Deploy fossid_integration_stateless_diffscan_target_repo action

RRD 1.2.9 release changelog updates

534594c

Merge branch 'release/1.2.9' into main

300d29e

Merge tag '1.2.9' into develop

d790168

RRD 1.2.9 release

Copilot AI review requested due to automatic review settings December 4, 2025 23:03

Copilot started reviewing on behalf of shibu-kv December 4, 2025 23:04 View session

Copilot finished reviewing on behalf of shibu-kv December 4, 2025 23:04

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Vismalskumar0 and others added 2 commits January 12, 2026 13:55

Copilot AI review requested due to automatic review settings January 21, 2026 19:27

Copilot started reviewing on behalf of shibu-kv January 21, 2026 19:27 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

nhanasi and others added 4 commits January 22, 2026 19:45

RRD 1.3.1 release changelog updates

20c9146

Merge branch 'release/1.3.1'

0c46729

Merge tag '1.3.1' into develop

c613c0b

RRD release 1.3.1

Copilot AI review requested due to automatic review settings February 17, 2026 16:08

Copilot started reviewing on behalf of nhanasi February 17, 2026 16:09 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

madhubabutt and others added 4 commits February 25, 2026 15:11

1.3.2 release changelog updates

6c61471

Merge branch 'release/1.3.2'

e0491f6

Merge tag '1.3.2' into develop

8f793e6

Remote Debugger 1.3.2 release

Copilot AI review requested due to automatic review settings March 20, 2026 19:00

Copilot started reviewing on behalf of nhanasi March 20, 2026 19:01 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

-        /* split into prefix and name */
-        size_t prefix_len = name_len - 100 - 1; /* leave room for null */
-        if (prefix_len > sizeof(hdr.prefix)) {
-            RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",
-                    __FUNCTION__, name, name_len);
-            return -1;
-        }
-        strncpy(hdr.prefix, name, prefix_len);
-        hdr.prefix[prefix_len < sizeof(hdr.prefix) ? prefix_len : sizeof(hdr.prefix) - 1] = '\0';
-        strncpy(hdr.name, name + prefix_len + 1, sizeof(hdr.name) - 1);
-        hdr.name[sizeof(hdr.name) - 1] = '\0';
+        /* split into prefix and name at a '/' boundary according to POSIX ustar */
+        size_t split_index = (size_t)-1;
+        size_t prefix_len = 0;
+        size_t name_part_len = 0;
+        /* search for the rightmost '/' that yields valid prefix/name lengths */
+        for (size_t i = name_len; i > 0; --i) {
+            if (name[i - 1] == '/') {
+                size_t p_len = i - 1;           /* characters before '/' */
+                size_t n_len = name_len - i;    /* characters after '/' */
+                if (p_len > 0 &&
+                    p_len <= sizeof(hdr.prefix) - 1 &&
+                    n_len > 0 &&
+                    n_len <= sizeof(hdr.name) - 1) {
+                    split_index = i - 1;
+                    prefix_len = p_len;
+                    name_part_len = n_len;
+                    break;
+                }
+            }
+        }
+        if (split_index == (size_t)-1) {
+            RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s] File name too long: %s (length %zu)\n",
+                    __FUNCTION__, name, name_len);
+            return -1;
+        }
+        /* copy prefix and name parts, ensuring null termination */
+        strncpy(hdr.prefix, name, prefix_len);
+        hdr.prefix[prefix_len] = '\0';
+        strncpy(hdr.name, name + split_index + 1, name_part_len);
+        hdr.name[name_part_len] = '\0';

	echo "AA:BB:CC:DD:EE:FF" >> /tmp/.estb_mac
	echo "AA:BB:CC:DD:EE:FF" > /tmp/.estb_mac

		THERMAL_TEMPERATURE_CRITICAL = 4 /* Critial Thermal Temperature */
		} PowerController_ThermalTemperature_t;

Conversation

Abhinavpv28 commented May 17, 2025

Uh oh!

CLAassistant commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

CLAassistant commented May 17, 2025 •

edited

Loading